On Wed, 2006-12-13 at 16:35 -0800, David Miller wrote:
> From: Sridhar Samudrala <[EMAIL PROTECTED]>
> Date: Wed, 13 Dec 2006 12:44:52 -0800
>
> > diff --git a/include/linux/sctp.h b/include/linux/sctp.h
> > index 35108fe..d4f8656 100644
> > --- a/include/linux/sctp.h
> > +++ b/include/linux/sctp.h
> > @@ -180,7 +180,7 @@ typedef enum {
> > SCTP_PARAM_ERR_CAUSE = __constant_htons(0xc003),
> > SCTP_PARAM_SET_PRIMARY = __constant_htons(0xc004),
> > SCTP_PARAM_SUCCESS_REPORT = __constant_htons(0xc005),
> > - SCTP_PARAM_ADAPTION_LAYER_IND = __constant_htons(0xc006),
> > + SCTP_PARAM_ADAPTATION_LAYER_IND = __constant_htons(0xc006),
> >
> > } sctp_param_t; /* enum */
> >
>
> I don't care what the API draft says, you will break existing
> userspace applications by changing this define.
>
> Please keep around a compatible define, and then add the new one.
These parameters are not used by user-space apps. They define the
parameters used by the protocol in SCTP headers that go on wire.
The kernel version of SCTP user-space API is present in
include/net/sctp/user.h and this patch does modify names of a socket
option, notification and fields in the associated structures.
But user-space should not use any SCTP kernel header files. It gets this
API via include/netinet/sctp.h that is included in lksctp-tools package.
This patch will not break any existing apps that use the
library/header-file from the released versions of lksctp-tools.
I will add compatible defines in the next release of lksctp-tools so
that it can be used with old apps as well as new apps that can use
the new names.
Thanks
Sridhar
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
