On Thu, Jan 17, 2019 at 03:03:08PM -0800, Nicholas Nunley wrote: > Move option parsing code into find_option function. > > No behavior changes. > > Based on patch by Kan Liang <kan.li...@intel.com> > > Signed-off-by: Nicholas Nunley <nicholas.d.nun...@intel.com>
Well, after looking at this series for a while I had decided to apply it. But when I applied it and did a 'make distcheck', I got this: ... gcc -DTEST_ETHTOOL -g -O2 -o test-features test_features-test-features.o test_features-test-common.o test_features-ethtool.o test_features-rxclass.o test_features-amd8111e.o test_features-de2104x.o test_features-dsa.o test_features-e100.o test_features-e1000.o test_features-et131x.o test_features-igb.o test_features-fec_8xx.o test_features-ibm_emac.o test_features-ixgb.o test_features-ixgbe.o test_features-natsemi.o test_features-pcnet32.o test_features-realtek.o test_features-tg3.o test_features-marvell.o test_features-vioc.o test_features-smsc911x.o test_features-at76c50x-usb.o test_features-sfc.o test_features-stmmac.o test_features-sff-common.o test_features-sfpid.o test_features-sfpdiag.o test_features-ixgbevf.o test_features-tse.o test_features-vmxnet3.o test_features-qsfp.o test_features-fjes.o test_features-lan78xx.o -lm make[2]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make check-TESTS make[2]: Entering directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make[3]: Entering directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' FAIL: test-cmdline PASS: test-features ============================================================================ Testsuite summary for ethtool 4.19 ============================================================================ # TOTAL: 2 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to netdev@vger.kernel.org ============================================================================ make[3]: *** [Makefile:1942: test-suite.log] Error 1 make[3]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make[2]: *** [Makefile:2050: check-TESTS] Error 2 make[2]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make[1]: *** [Makefile:2264: check-am] Error 2 make[1]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make: *** [Makefile:2186: distcheck] Error 1 ... I'll attach ./ethtool-4.19/_build/sub/test-suite.log to this message. Obviously we need whatever additional changes are needed to get 'make check-TESTS' to pass legitimately. John -- John W. Linville Someday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.
==================================== ethtool 4.19: ./test-suite.log ==================================== # TOTAL: 2 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test-cmdline ================== E: ethtool -s devname returns 1 E: ethtool --change devname speed 100 duplex half mdix auto returns 1 E: ethtool -s devname duplex half returns 1 E: ethtool --change devname port tp returns 1 E: ethtool -s devname autoneg on returns 1 E: ethtool --change devname advertise 0x1 returns 1 E: ethtool --change devname advertise 0xf returns 1 E: ethtool --change devname advertise 0Xf returns 1 E: ethtool --change devname advertise 1 returns 1 E: ethtool --change devname advertise f returns 1 E: ethtool --change devname advertise 01 returns 1 E: ethtool --change devname advertise 0f returns 1 E: ethtool --change devname advertise 0xfffffffffffffffffffffffffffffffff returns 1 E: ethtool --change devname advertise fffffffffffffffffffffffffffffffff returns 1 E: ethtool --change devname advertise 0x0000fffffffffffffffffffffffffffff returns 1 E: ethtool --change devname advertise 0000fffffffffffffffffffffffffffff returns 1 E: ethtool -s devname phyad 1 returns 1 E: ethtool --change devname xcvr external returns 1 E: ethtool -s devname wol p returns 1 E: ethtool -s devname sopass 01:23:45:67:89:ab returns 1 E: ethtool -s devname msglvl 1 returns 1 E: ethtool -s devname msglvl hw on rx_status off returns 1 E: ethtool --change devname speed 100 duplex half port tp autoneg on advertise 0x1 phyad 1 xcvr external wol p sopass 01:23:45:67:89:ab msglvl 1 returns 1 FAIL test-cmdline (exit status: 1)
