On Mon, Dec 11, 2006 at 10:16:30AM -0500, Jeff Garzik ([EMAIL PROTECTED]) wrote:
> Comments:
>
> * [oh, everybody will hate me for saying this, but...] to me, "kevent"
> implies an internal kernel subsystem. I would rather call it "uevent"
> or anything else lacking a 'k' prefix.
It is kernel subsystem indeed, which exports some of its part to
userspace.
I previously thought that prefix 'k' can only be confused with KDE.
> * I like the absolute timespec (and use of timespec itself)
And I do not, but I made them to make at least some progress.
> * more on naming: I think kevent_open would be more natural than
> kevent_init, since it opens a file descriptor.
It is also initializes ring buffer.
> * why is KEVENT_MAX not equal to KEVENT_POSIX_TIMER? (perhaps answer
> this question in a comment, if it is not a mistake)
I check for error number using '>=' and use it as array size,
so it is always bigger than the last entry id.
I will add a comment.
> * Kill all the CONFIG_KEVENT_xxx sub-options, or hide them under
> CONFIG_EMBEDDED. Application developers should NOT be left wondering
> whether or support for KEVENT_INODE was compiled into the kernel.
Ok, I will put them under !CONFIG_EMBEDDED.
--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
