On Fri, Jan 18, 2019 at 07:18:32AM +0000, Y.b. Lu wrote: > > We want to use "imply" instead of "select" here. > > [Y.b. Lu] Just learned the "imply" from the doc. I have a query here. > Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of > FSL_DPAA2_PTP_CLOCK driver may not work. > Doesn't it matter?
If PTP_1588_CLOCK is not compiled, then your driver should handle this case: * ptp_clock_register() - register a PTP hardware clock driver * Returns a valid pointer on success or PTR_ERR on failure. If PHC * support is missing at the configuration level, this function * returns NULL, and drivers are expected to gracefully handle that * case separately. Thanks, Richard