On 01/15/2019 10:03 AM, Sergei Shtylyov wrote: > On 14.01.2019 23:29, Mathieu Malaterre wrote: > >> There is a plan to build the kernel with -Wimplicit-fallthrough and >> thise place in the code produced a warnings (W=1). > > This? > >> In this particular case change a ‘:’ with a ‘,’ so as to match the >> regular expression expected by GCC. >> >> This commit remove the following warning: >> >> net/core/filter.c:5310:6: warning: this statement may fall through >> [-Wimplicit-fallthrough=] >> >> Signed-off-by: Mathieu Malaterre <ma...@debian.org>
Please respin and also make the two subject lines not exactly the same. Thanks, Daniel >> --- >> net/core/filter.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/core/filter.c b/net/core/filter.c >> index 447dd1bad31f..c8069a142994 100644 >> --- a/net/core/filter.c >> +++ b/net/core/filter.c >> @@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id) >> case BPF_FUNC_trace_printk: >> if (capable(CAP_SYS_ADMIN)) >> return bpf_get_trace_printk_proto(); >> - /* else: fall through */ >> + /* else, fall through */ > > The other patches seem to just drop "else:"... > >> default: >> return NULL; >> } >> > > MBR, Sergei
