On Tue, Jan 15, 2019 at 7:59 AM Jamal Hadi Salim <j...@mojatatu.com> wrote: > > On 2019-01-13 4:08 p.m., Cong Wang wrote: > > On Sat, Jan 12, 2019 at 7:41 AM Jamal Hadi Salim <j...@mojatatu.com> wrote: > >> > >> On 2019-01-12 7:23 a.m., Jamal Hadi Salim wrote: > >> > >>> Do we have a test case for a setup like this in tdc? > >>> i.e incoming tagged and then vlan popped by action? > >>> Otherwise a test with IFE which resets the ethertype > >>> would be sufficient i.e just something that will messup > >>> with skb->protocol. > >> > >> And here is a slightly complex test with IFE. > >> Wanted to show both reclassify and continue in play > >> as well as something that change skb->protocol. > >> > > > > I don't know why you need a complex one, Martin's > > test case is pretty simple (as I already sent to you). > > > > Martin example had a "reclassify" with the vlan pop. > Your example was showing a "continue" > Note: "Reclassify" is typical how we have explained > to users to deal with skb->protocol changes.
You have to re-read Martin's example, he clearly showed "reclassify" works but not "continue". This is exactly why I have "continue" in my script, as I need to test what I fix. > Lets have Lucas give this a run and we can move > forward. Sure. Thanks.