On 1/7/19 9:38 PM, David Miller wrote:
> From: Ying Xue <ying....@windriver.com>
> Date: Mon, 7 Jan 2019 19:29:52 +0800
>
>> This is because lc->name string is not validated before it's used.
>
> It looks like we have several situations like this, not just this one.
>
> For example, tipc_nl_compat_bearer_{enable,disable}() with b->name.
>
> Next, tipc_nl_compat_media_set() and tipc_nl_compat_bearer_set().
>
> On input, tipc_nl_compat_link_stat_dump() blindly does a strcmp()
> on one of these strings.
>
> In fact, this entire file is full of errors of this sort.
>
> Can you please address all of them, perhaps using a helper of
> some kind to consolidate the logic?
>
Thank you for your good suggestions. I will solve them as soon as possible.
Regards,
Ying
> Thank you.
>
