From: Michael Schmitz <schmitz...@gmail.com> Date: Sat, 22 Dec 2018 10:30:58 +1300
> Am 21.12.2018 um 13:10 schrieb David Miller: >> And in particular this huge complicated Kconfig construct is not >> maintainable at all. > > We can trim this down a bit (for reasons I've outlined before): > > +if APNE > +config APNE100MBIT > + bool "PCMCIA NE2000 100MBit support" > + default n > + depends on NE2000=n && PCMCIA_AXNET=n > + depends on PCMCIA_PCNET=n && STNIC=n && ULTRA=n && WD80x3=n > > In all honesty, I doubt anyone could ever use the stnic, ultra and wd > drivers on m68k (Geert?) so these could be omitted as well. Not sure > pcnet_cs or axnet_cs are possible to use on the Amiga PCMCIA slot, so > all that remains in practice is the ne driver (which is used on > Atari). > > Still too ugly? I'm sorry, maybe I didn't express my concern clearly. Any sizable list of exceptions in a Kconfig conditional has long term maintainence costs. If, for some reason, a new variant of support for this chip arrives there will be a new Kconfig setting that would need to be added here to your expressions. That is insanely error prone, and I can guarantee it will get missed. Having so many front end drivers for a chipset should be done in a more modular manner, so that in fact they could all coexist if necessary.
