On Sun, Dec 23, 2018 at 06:23:18PM +0100, Heiner Kallweit wrote:
> On 23.12.2018 18:07, Andrew Lunn wrote:
> > On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote:
> >> Currently we return immediately if callback config_init isn't defined.
> >> This prevents the fixups from being executed. I see no dependency
> >> between fixups and config_init, therefore change the function to
> >> run the fixups also if config_init isn't defined.
> >>
> >> Fixes: 2f5cb43406d0 ("phylib: Properly reinitialize PHYs after
> >> hibernation")
> >> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
> >
> > Hi Heiner
> >
> > Is this a real fix? It seems like it has been like this forever. Do
> > you know of a PHY which is actually broken?
> >
> Right, the current behavior has been there forever. I'm not aware of
> any concrete case. I went for "net" because the current code could
> break a device.
Hi Heiner
https://www.kernel.org/doc/html/v4.15/process/stable-kernel-rules.html
The 4th bullet point:
o It must fix a real bug that bothers people (not a, “This could be a
problem...” type thing).
Andrew
