On Sun, 3 Dec 2006 11:45:09 +0100 "Eric Lemoine" <[EMAIL PROTECTED]> wrote:
> Stephen, > > On 12/2/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > If transmit lock is contended on, then push return code back > > and retry at higher level. > > Looking at qdisc_restart, it seems to me that the NETDEV_TX_LOCKED > return code must only be used if the device features LLTX. With your > patch, if q->lock is already grabbed, qdisc_restart is going to > requeue skb without going through the collision section of > qdisc_restart. > The Chelsio driver already sets LLTX (see drivers/net/chelsio/cxgb2.c) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html