* Patrick McHardy <[EMAIL PROTECTED]> 2006-12-04 17:39 > It just seems this code is entirely useless and the only > thing it does is cause short term unexpected behaviour > during the race I mentioned.
Yes, the whole head == NULL branch should be removed. > One thing we should probably do is to move the tp->root > allocation to the init function in cls_fw and the others > implementing it as dummy to at least close the race > between ->init and ->change. I'll look into that as a > follow-up patch. Right, allocating the head in init with a mask of 0xFFFFFFFF and then allow the user to overwrite it seems to make most sense. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html