I handed over ethtool to John Linville some time ago. Ben.
On Fri, 2018-12-14 at 17:19 -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <m...@google.com>
>
> prior to fetching it from kernel.
>
> Otherwise we run the risk of very tail portion of it (dmac field)
> being left entirely uninitialized, and likely containing some sort
> of stale data.
>
> It seems to likely be some sort of time (a second's counter).
>
> Tested:
> 'ethtool -c eth1' with old kernel now reports 'dmac: 0' where
> previously it reported some sort of second counter.
>
> Signed-off-by: Maciej Żenczykowski <m...@google.com>
> ---
> ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ethtool.c b/ethtool.c
> index 2f7e96bb58db..465eeecb9318 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -2076,7 +2076,7 @@ static int do_gchannels(struct cmd_context *ctx)
>
> static int do_gcoalesce(struct cmd_context *ctx)
> {
> - struct ethtool_coalesce ecoal;
> + struct ethtool_coalesce ecoal = {};
> int err;
>
> if (ctx->argc != 0)
--
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.
signature.asc
Description: This is a digitally signed message part
