On Tue, Dec 11, 2018 at 1:44 PM Jakub Kicinski
<jakub.kicin...@netronome.com> wrote:
>
> On Tue, 11 Dec 2018 11:15:46 -0800, Cong Wang wrote:
> > After commit 69bd48404f25 ("net/sched: Remove egdev mechanism"),
> > tc_setup_cb_call() is nearly identical to tcf_block_cb_call(),
> > so we can just fold tcf_block_cb_call() into tc_setup_cb_call()
> > and remove its unused parameter 'exts'.
> >
> > Fixes: 69bd48404f25 ("net/sched: Remove egdev mechanism")
> > Cc: Oz Shlomo <o...@mellanox.com>
> > Cc: Jiri Pirko <j...@mellanox.com>
> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
>
> Thanks, I didn't want to nit pick too much on Oz's patch :)
>
> The Fixes tag is superfluous, this is far from a bug, unnecessary noise
> for backporters.
Odd, you just Acked a patch which uses Fixes tag for a newline
change:
commit 10a5ce98539948affbdc28dc0f39a1b6b2307f9d
Author: Martin KaFai Lau <ka...@fb.com>
Date: Mon Dec 10 10:53:24 2018 -0800
bpf: bpftool: Fix newline and p_err issue
This patch fixes a few newline issues and also
replaces p_err with p_info in prog.c
Fixes: b053b439b72a ("bpf: libbpf: bpftool: Print bpf_line_info
during prog dump")
Cc: Jakub Kicinski <jakub.kicin...@netronome.com>
Signed-off-by: Martin KaFai Lau <ka...@fb.com>
Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com>
Signed-off-by: Alexei Starovoitov <a...@kernel.org>
Jakub, please guide me which Jakub I should trust. :)
Or you believe a newline change is more close to a bug fix
than this?
Please help!
Thanks a lot!
