Adrian Bunk wrote: > Considering that NET_CLS_POLICE has been marked as obsolete for more > than one year, would a patch to remove it be acceptable?
Looking at this, the only reason I thought why we kept this option was to keep old iproute binaries working. But struct tc_police in new kernels is bigger than in old ones (new refcnt, bindcnt and capab members) and both the old and the action version of the policer check for an exact size match. Which means old binaries don't work with either NET_CLS_POLICE or NET_ACT_POLICE. I'll look into fixing this. One more thing NET_CLS_POLICE affects is CBQ reshape/reclassify handling, reshape_fail seems to be completely unhandled without NET_CLS_POLICE and reclassification looks like it behaves differently with tc actions. I'm not really sure what the reshape_fail stuff is used for, but it looks like we would loose a feature. Jamal? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
