On Sat, 2006-11-25 at 23:05 -0500, Daniel Drake wrote: > Surely disabling the queue actually makes sense, in order to avoid > frames designated for the "current session" being transmitted on > different channels during scanning?
The problem is that queue disabling isn't refcounted so that a scan that collides with bcm43xx having disabled the queue for calibration might re-enable the queue while bcm43xx is still calibrating. Clearly, this doesn't fully fix the problem because softmac will try to transmit frames during the calibration. Hence, a proper fix would be to not remove the calls to netif_tx_disable but make them go through softmac (ieee80211_tx_disable) to make sure that softmac doesn't try to scan while the queues are disabled, which would fix the aforementioned problem of softmac enabling the queue while the driver needs it disabled for free. johannes
signature.asc
Description: This is a digitally signed message part
