Jesper Juhl <[EMAIL PROTECTED]> wrote: > > So if 'skb' is NULL, the only route I see that doesn't cause a NULL > pointer deref is if (opt != NULL) and at the same time > (opt->is_data != NULL) . Is that guaranteed in any way? If now, > how come we don't blow up regularly?
Yes that's how it's supposed to be used. This function either constructs an opts structure from a packet, or it verifies the validity of a suspect opts structure (without a packet). In the latter case, both opt and opt->is_data should be non-zero. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html