From: Nivedita Singhvi <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 15:17:06 -0800
WATCH YOUR QUOTING! > David Miller wrote: > > From: Brian Haley <[EMAIL PROTECTED]> > > Date: Fri, 10 Nov 2006 11:24:45 -0500 > > > >> Only change upper-layer checksum from 0 to 0xFFFF for UDP (as RFC 768 > >> states), not for others as RFC 4443 doesn't require it. > >> > >> Signed-off-by: Brian Haley <[EMAIL PROTECTED]> > > > > Applied, thanks Brian. I applied Brian's FIRST PATCH, which is fine. > Brian Haley wrote: > > Al Viro wrote: > >> Could you fscking read what you've replied to? Your -=1 will turn 0 > >> into 0xffff instead of correct 0xfffe. IOW, it's broken in 1:65536 > >> cases. > > > > I looked again at your previous email: > > > >> Note that even on little-endian you want > >> 3 -> 2 > >> 2 -> 1 > >> 1 -> 0xffff > >> 0 -> 0xfffe > > > > That doesn't look right to me, but I'll take your word that there's one > > edge case out there I don't see (even though this worked on Alpha). > > Forget about the patch then. > > Er, given all of the above, Brian, could you share your test cases > and/or other/any information on testing this? This is a discussion about Brian's SECOND PATCH which needs fixups. Please don't quote things out of context like this! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
