On Mon, 6 Nov 2006 15:26:33 -0600
Andy Fleming <[EMAIL PROTECTED]> wrote:
 
> You are passing extra arguments, here

Oh yes, thanks. I was out of sync here.

> 1) Do we need the disable/enable irq stuff?  It seems like we should  
> be able to either just *mask* the interrupts at the controller, or  
> rely on the locks to disable the interrupts.

I don't see how masking the ints at the controller differs much from 
disable_irq.
Locking all the interrupts is definitely worse than disabling selected ones. 
Also, introducing locks here means that we'll need to handle that specifically 
for -rt kernels.
 
> 2) If we are calling gfar_transmit and gfar_receive, shouldn't we  
> call gfar_error?
> 
> 3) I think it should be possible to just call gfar_interrupt() in  
> every situation, but I'm not very familiar with net poll's  
> requirements (You can add that into your evaluation of #1, too).

Oh yes, that's a nice idea, thanks.

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to