On Fri, 2006-11-03 at 17:43 -0500, Michael Wu wrote: > But bcm43xx sets ethtool ops through bcm43xx_netdev_setup. Why not have > rt2x00 > do the same?
Actually, look closer. I removed bcm43xx_netdev_setup as well as the setup() callback for the hw as well as the bcm43xx ethtool ops which were useless anyway. > Then we won't have to go through all the trouble of adding > things to ieee80211_hw and ieee80211_register_hw to set things in net_device. > This would work out pretty well for SET_NETDEV_DEV too. No. We have to add these things anyway if we want them copied to the slave netdevs. Besides, the driver has no business mucking with the netdevs. johannes
signature.asc
Description: This is a digitally signed message part
