On 11/26/18 9:32 AM, Alexis Bauvin wrote: > Thanks for the review. I’ll send a v5 if you have no other comment on > this version!
A few comments on the test script; see attached which has the changes. Mainly the cleanup does not need to be called at the end since you setup the exit trap. The cleanup calls ip to delete veth-hv-1 and veth-tap but those are moved to other namespaces. 'ip netns exec NAME ip ...' is more efficiently done as 'ip -netns NAME ...'. The test results should align like this: Checking HV connectivity [ OK ] Check VM connectivity through VXLAN (underlay in the default VRF) [ OK ] Check VM connectivity through VXLAN (underlay in a VRF) [ OK ] So it is easy for users to see the PASS/FAIL. It would be good to copy the topology ascii art into the test script as well for future users. Also, add the test as a separate patch at the end and include it in tools/testing/selftests/net/Makefile Finally, I think you should drop the RFC and send it as a 'ready for inclusion'.
test_vxlan_under_vrf.sh
Description: Bourne shell script
