On 11/22/18 1:26 AM, Toke Høiland-Jørgensen wrote: > Saeed Mahameed <sae...@mellanox.com> writes: > >>>> I'd say it sounds reasonable to include XDP in the normal traffic >>>> counters, but having the detailed XDP-specific counters is quite >>>> useful >>>> as well... So can't we do both (for all drivers)? >>>> >> >> What are you thinking ? >> reporting XDP_DROP in interface dropped counter ? >> and XDP_TX/REDIRECT in the TX counter ? >> XDP_ABORTED in the err/drop counter ? >> >> how about having a special XDP command in the .ndo_bpf that would query >> the standardized XDP stats ? > > Don't have any strong opinions on the mechanism; just pointing out that > the XDP-specific stats are useful to have separately as well :) >
I would like to see basic packets, bytes, and dropped counters tracked for Rx and Tx via the standard netdev counters for all devices. This is for ease in accounting as well as speed and simplicity for bumping counters for virtual devices from bpf helpers. >From there, the XDP ones can be in the driver private stats as they are currently but with some consistency across drivers for redirects, drops, any thing else. So not a radical departure from where we are today, just getting the agreement for consistency and driver owners to make the changes.
