On Mon, Nov 19, 2018 at 03:17:43PM +0100, Jiri Pirko wrote: > Mon, Nov 19, 2018 at 01:15:16AM CET, pa...@netfilter.org wrote: [...] > >diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h > >index 7a4683646d5a..ec9036232538 100644 > >--- a/include/net/flow_dissector.h > >+++ b/include/net/flow_dissector.h [...] > >+struct flow_rule *ethtool_rx_flow_rule(const struct ethtool_rx_flow_spec > >*fs) [...] > Code that is doing ethtool->flow_rule conversion should be in ethtool > code. You should just provide helpers here (in flow.c) that could be > used to assemble the flow_rule structure.
OK, will place this in ethtool file.