On Fri, Nov 16, 2018 at 01:32:50PM -0800, Cong Wang wrote: > > This is true only when there is a skb_checksum_init*() or > skb_checksum_validate*() prior to it, it seems not true for > nf_ip_checksum() where skb->csum is correctly set to pesudo header > checksum but there is no validation of the original skb->csum. > So this check should be still inverted there?? > > Or am I still missing anything here?
What do you mean? My copy of nf_ip_checksum seems to be doing the right thing as far as verifying CHECKSUM_COMPLETED goes. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt