(Cc'ing Jamal)
On Wed, Nov 14, 2018 at 3:26 AM Davide Caratti <[email protected]> wrote:
>
> tcf_idr_check_alloc() can return a negative value, on allocation failures
> (-ENOMEM) or IDR exhaustion (-ENOSPC): don't leak keys_ex in these cases.
I think the comments above tcf_idr_check_alloc() need to improve too,
they imply tcf_idr_check_alloc() returns either 0 or 1.
Of course, this can be done with a separated patch.
>
> Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
> Signed-off-by: Davide Caratti <[email protected]>
I think your patch is correct.
Acked-by: Cong Wang <[email protected]>
