From: Sudarsana Reddy Kalluru <sudarsana.kall...@cavium.com> Date: Fri, 9 Nov 2018 02:10:43 -0800
> +/* Following is the DMAE channel number allocation for the clients. > + * MFW: OCBB/OCSD implementations use DMAE channels 14/15 respectively. > + * Driver: 0-3 and 8-11 (for PF dmae operations) > + * 4 and 12 (for stats requests) > + */ > +#define BNX2X_FW_DMAE_C 13 /* Channel for FW DMAE operations > */ ... > + start_params->dmae_cmd_id = BNX2X_FW_DMAE_C; Why do you need this, it never changes, and: > + rdata->dmae_cmd_id = start_params->dmae_cmd_id; It always is the same value here in the one place it is used. Just assign BNX2X_FW_DMAE_C directly to rdata->dmae_cmd_id please.