On Sun, 2006-10-29 at 23:46 -0800, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Mon, 30 Oct 2006 18:11:28 +1100 > > > [SCTP]: Always linearise packet on input > ... > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > I'll apply this, thanks a lot. > > > Sridhar, could you please organise an audit of SCTP to make sure > > that it deals with skb fragments (both pages and frag_list) in a > > safe manner? Basically before you do an skb_pull or access skb->data > > you must ensure that the data you want to access is in the head, > > usually by doing skb_may_pull. Of course, for large payloads it > > helps if you can avoid pulling it into the head. > > Of course, you mean "pskb_may_pull" here.
I think we currently assume atleast the SCTP header and the data chunk header to be in the skb head. But we do handle skbs with data in the frag_list. Not sure about skb's with paged fragments. Does XEN use frag_list or frags array? Is there a simple way to simulate incoming packets with transport headers and data in skb's frag_list/pages without having to use XEN. Thanks Sridhar - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
