From: Saeed Mahameed <sae...@mellanox.com>
Date: Mon, 5 Nov 2018 19:13:59 +0000

> On Sat, 2018-11-03 at 19:36 -0700, David Miller wrote:
>> From: Saeed Mahameed <sae...@mellanox.com>
>> Date: Fri,  2 Nov 2018 18:54:22 -0700
>> 
>> > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct
>> > rtnl_link_stats64 *s)
>> > +{
>> > +  int i;
>> > +
>> > +  /* not required ? */
>> > +  memset(s, 0, sizeof(*s));
>> 
>> Why wouldn't this be required?
>> 
> 
> I just checked it is already done by the stack @dev_get_stats()

Then please document this in the commit message or similar.

Reply via email to