On 31/10/2018 5:39 PM, Eric Dumazet wrote: > doorbell only depends on xmit_more and netif_tx_queue_stopped() > > Using __netdev_tx_sent_queue() avoids messing with BQL stop flag, > and is more generic. > > This patch increases performance on GSO workload by keeping > doorbells to the minimum required. > > Signed-off-by: Eric Dumazet <eduma...@google.com> > Cc: Tariq Toukan <tar...@mellanox.com> > --- > drivers/net/ethernet/mellanox/mlx4/en_tx.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c > b/drivers/net/ethernet/mellanox/mlx4/en_tx.c > index > 1857ee0f0871d48285a6d3711f7c3e9a1e08a05f..6f5153afcab4dfc331c099da854c54f1b9500887 > 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c > @@ -1006,7 +1006,6 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct > net_device *dev) > ring->packets++; > } > ring->bytes += tx_info->nr_bytes; > - netdev_tx_sent_queue(ring->tx_queue, tx_info->nr_bytes); > AVG_PERF_COUNTER(priv->pstats.tx_pktsz_avg, skb->len); > > if (tx_info->inl) > @@ -1044,7 +1043,10 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct > net_device *dev) > netif_tx_stop_queue(ring->tx_queue); > ring->queue_stopped++; > } > - send_doorbell = !skb->xmit_more || netif_xmit_stopped(ring->tx_queue); > + > + send_doorbell = __netdev_tx_sent_queue(ring->tx_queue, > + tx_info->nr_bytes, > + skb->xmit_more); > > real_size = (real_size / 16) & 0x3f; > >
Reviewed-by: Tariq Toukan <tar...@mellanox.com> Looks good to me. Thanks.
