On 10/29/2018 11:09 PM, Dimitris Michailidis wrote: > > Indeed this is a bug. I would expect it to produce frequent errors > though as many odd-length > packets would trigger it. Do you have RXFCS? Regardless, how > frequently do you see the problem? > Old kernels (before 88078d98d1bb) were simply resetting ip_summed to CHECKSUM_NONE And before your fix (commit d55bef5059dd057bd), mlx5 bug was canceling the bug you fixed. So we now need to also fix mlx5. And of course use skb_header_pointer() in mlx5e_get_fcs() as I mentioned earlier, plus __get_unaligned_cpu32() as you hinted.
- Latest net-next kernel 4.19.0+ Paweł Staszewski
- Re: Latest net-next kernel 4.19.0+ Paweł Staszewski
- Re: Latest net-next kernel 4.19.0+ Paweł Staszewski
- Re: Latest net-next kernel 4.19.0+ Cong Wang
- Re: Latest net-next kernel 4.19.0+ Cong Wang
- Re: Latest net-next kernel 4.19.0+ Eric Dumazet
- Re: Latest net-next kernel 4.19.0+ Eric Dumazet
- Re: Latest net-next kernel 4.19... Dimitris Michailidis
- Re: Latest net-next kernel ... Eric Dumazet
- Re: Latest net-next ker... Paweł Staszewski
- Re: Latest net-next ker... Eric Dumazet
- Re: Latest net-next ker... Cong Wang
- Re: Latest net-next ker... Eric Dumazet
- Re: Latest net-next ker... Cong Wang
- Re: Latest net-next ker... Saeed Mahameed
- Re: Latest net-next ker... Cong Wang
- Re: Latest net-next ker... Cong Wang
- Re: Latest net-next ker... Paweł Staszewski
- Re: Latest net-next ker... Paweł Staszewski