From: Jakub Kicinski <jakub.kicin...@netronome.com> Date: Fri, 26 Oct 2018 15:51:06 -0700
> gred_change_table_def() takes a pointer to TCA_GRED_DPS attribute, > and expects it will be able to interpret its contents as > struct tc_gred_sopt. Pass the correct gred attribute, instead of > TCA_OPTIONS. > > This bug meant the table definition could never be changed after > Qdisc was initialized (unless whatever TCA_OPTIONS contained both > passed netlink validation and was a valid struct tc_gred_sopt...). ... > Fixes: f62d6b936df5 ("[PKT_SCHED]: GRED: Use central VQ change procedure") > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Quite an ancient bug :-) Applied and queued up for -stable, thanks!