Tobias Jungel <tobias.jun...@gmail.com> wrote: >The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the >length of sizeof(bond->params.ad_actor_system) which is 8 byte. This >patch aligns the length to ETH_ALEN to have the same MAC address exposed >as using sysfs. > >fixes f87fda00b6ed2 > >Signed-off-by: Tobias Jungel <tobias.jun...@gmail.com>
The patch looks fine to me, but the "fixes" line is not formatted properly. Please format it according to Documentation/process/submitting-patches.rst and resubmit your patch as V2. -J >--- > drivers/net/bonding/bond_netlink.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/drivers/net/bonding/bond_netlink.c >b/drivers/net/bonding/bond_netlink.c >index 9697977b80f0..6b9ad8673218 100644 >--- a/drivers/net/bonding/bond_netlink.c >+++ b/drivers/net/bonding/bond_netlink.c >@@ -638,8 +638,7 @@ static int bond_fill_info(struct sk_buff *skb, > goto nla_put_failure; > > if (nla_put(skb, IFLA_BOND_AD_ACTOR_SYSTEM, >- sizeof(bond->params.ad_actor_system), >- &bond->params.ad_actor_system)) >+ ETH_ALEN, &bond->params.ad_actor_system)) > goto nla_put_failure; > } > if (!bond_3ad_get_active_agg_info(bond, &info)) { > --- -Jay Vosburgh, jay.vosbu...@canonical.com