Hi Huazhong, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Huazhong-Tan/Bugfix-for-the-HNS3-driver/20181027-105711 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=xtensa All errors (new ones prefixed by >>): >> drivers/net/ethernet//hisilicon/hns3/hns3vf/hclgevf_main.c:2169:22: error: >> initialization of 'int (*)(struct hnae3_handle *, bool, bool)' {aka 'int >> (*)(struct hnae3_handle *, _Bool, _Bool)'} from incompatible pointer type >> 'void (*)(struct hnae3_handle *, bool, bool)' {aka 'void (*)(struct >> hnae3_handle *, _Bool, _Bool)'} [-Werror=incompatible-pointer-types] .set_promisc_mode = hclgevf_set_promisc_mode, ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet//hisilicon/hns3/hns3vf/hclgevf_main.c:2169:22: note: (near initialization for 'hclgevf_ops.set_promisc_mode') cc1: some warnings being treated as errors vim +2169 drivers/net/ethernet//hisilicon/hns3/hns3vf/hclgevf_main.c c136b8842 Peng Li 2018-09-21 2156 e2cb1dec9 Salil Mehta 2017-12-14 2157 static const struct hnae3_ae_ops hclgevf_ops = { e2cb1dec9 Salil Mehta 2017-12-14 2158 .init_ae_dev = hclgevf_init_ae_dev, e2cb1dec9 Salil Mehta 2017-12-14 2159 .uninit_ae_dev = hclgevf_uninit_ae_dev, e718a93fe Peng Li 2018-06-28 2160 .init_client_instance = hclgevf_init_client_instance, e718a93fe Peng Li 2018-06-28 2161 .uninit_client_instance = hclgevf_uninit_client_instance, e2cb1dec9 Salil Mehta 2017-12-14 2162 .start = hclgevf_ae_start, e2cb1dec9 Salil Mehta 2017-12-14 2163 .stop = hclgevf_ae_stop, e2cb1dec9 Salil Mehta 2017-12-14 2164 .map_ring_to_vector = hclgevf_map_ring_to_vector, e2cb1dec9 Salil Mehta 2017-12-14 2165 .unmap_ring_from_vector = hclgevf_unmap_ring_from_vector, e2cb1dec9 Salil Mehta 2017-12-14 2166 .get_vector = hclgevf_get_vector, 0d3e6631d Yunsheng Lin 2018-03-09 2167 .put_vector = hclgevf_put_vector, e2cb1dec9 Salil Mehta 2017-12-14 2168 .reset_queue = hclgevf_reset_tqp, e2cb1dec9 Salil Mehta 2017-12-14 @2169 .set_promisc_mode = hclgevf_set_promisc_mode, e2cb1dec9 Salil Mehta 2017-12-14 2170 .get_mac_addr = hclgevf_get_mac_addr, e2cb1dec9 Salil Mehta 2017-12-14 2171 .set_mac_addr = hclgevf_set_mac_addr, e2cb1dec9 Salil Mehta 2017-12-14 2172 .add_uc_addr = hclgevf_add_uc_addr, e2cb1dec9 Salil Mehta 2017-12-14 2173 .rm_uc_addr = hclgevf_rm_uc_addr, e2cb1dec9 Salil Mehta 2017-12-14 2174 .add_mc_addr = hclgevf_add_mc_addr, e2cb1dec9 Salil Mehta 2017-12-14 2175 .rm_mc_addr = hclgevf_rm_mc_addr, e2cb1dec9 Salil Mehta 2017-12-14 2176 .get_stats = hclgevf_get_stats, e2cb1dec9 Salil Mehta 2017-12-14 2177 .update_stats = hclgevf_update_stats, e2cb1dec9 Salil Mehta 2017-12-14 2178 .get_strings = hclgevf_get_strings, e2cb1dec9 Salil Mehta 2017-12-14 2179 .get_sset_count = hclgevf_get_sset_count, e2cb1dec9 Salil Mehta 2017-12-14 2180 .get_rss_key_size = hclgevf_get_rss_key_size, e2cb1dec9 Salil Mehta 2017-12-14 2181 .get_rss_indir_size = hclgevf_get_rss_indir_size, e2cb1dec9 Salil Mehta 2017-12-14 2182 .get_rss = hclgevf_get_rss, e2cb1dec9 Salil Mehta 2017-12-14 2183 .set_rss = hclgevf_set_rss, d97b30721 Jian Shen 2018-10-10 2184 .get_rss_tuple = hclgevf_get_rss_tuple, d97b30721 Jian Shen 2018-10-10 2185 .set_rss_tuple = hclgevf_set_rss_tuple, e2cb1dec9 Salil Mehta 2017-12-14 2186 .get_tc_size = hclgevf_get_tc_size, e2cb1dec9 Salil Mehta 2017-12-14 2187 .get_fw_version = hclgevf_get_fw_version, e2cb1dec9 Salil Mehta 2017-12-14 2188 .set_vlan_filter = hclgevf_set_vlan_filter, b2641e2ad Yunsheng Lin 2018-05-03 2189 .enable_hw_strip_rxvtag = hclgevf_en_hw_strip_rxvtag, 6d4c3981a Salil Mehta 2018-03-22 2190 .reset_event = hclgevf_reset_event, 849e46077 Peng Li 2018-01-12 2191 .get_channels = hclgevf_get_channels, cc719218e Peng Li 2018-03-08 2192 .get_tqps_and_rss_info = hclgevf_get_tqps_and_rss_info, 175ec96b4 Fuyun Liang 2018-03-21 2193 .get_status = hclgevf_get_status, 4a152de95 Fuyun Liang 2018-03-21 2194 .get_ksettings_an_result = hclgevf_get_ksettings_an_result, c136b8842 Peng Li 2018-09-21 2195 .get_media_type = hclgevf_get_media_type, e2cb1dec9 Salil Mehta 2017-12-14 2196 }; e2cb1dec9 Salil Mehta 2017-12-14 2197 :::::: The code at line 2169 was first introduced by commit :::::: e2cb1dec9779ba2d89302a653eb0abaeb8682196 net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support :::::: TO: Salil Mehta <salil.me...@huawei.com> :::::: CC: David S. Miller <da...@davemloft.net> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
