On Wed, 17 Oct 2018 15:23:14 -0700, Jeff Kirsher wrote: > +/** > + * igc_ioctl - I/O control method > + * @netdev: network interface device structure > + * @ifreq: frequency
Is it? :) > + * @cmd: command > + */ > +static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) > +{ > + switch (cmd) { > + default: > + return -EOPNOTSUPP; > + } > +} You don't seem to be adding anything to this function in the series. Why add the stub?