On Wed, Oct 17, 2018 at 04:24:48PM +0200, Nicolas Dichtel wrote: > len_diff is signed. > > Fixes: fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)") > CC: Quentin Monnet <quentin.mon...@netronome.com> > Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > --- > include/uapi/linux/bpf.h | 2 +- > tools/include/uapi/linux/bpf.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 66917a4eba27..c4ffe91d5598 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -1430,7 +1430,7 @@ union bpf_attr { > * Return > * 0 on success, or a negative error in case of failure. > * > - * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 > flags) > + * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 > flags)
Thanks. Applied to bpf-next, since we're very late into release cycle.