Pfifo_fast does not make sense because the 802.11 qdisc already categorizes the frames based on DSCP. The better thing would be to extract the pfifo qdisc so that it does not require NET_SCHED, but this is more work.
Simon -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Patrick McHardy Sent: Wednesday, October 25, 2006 4:29 PM To: David Kimdon Cc: netdev@vger.kernel.org; John W. Linville; Jiri Benc Subject: Re: [patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc David Kimdon wrote: > wme.c needs a generic fifo qdisc for each hardware queue. Switch > wme.c to use the generic fifo qdisc in net/sched/sch_fifo.c. This > allows removal of net/d80211/fifo_qdisc.c which isn't particularily > tied to IEEE 802.11 in any way. > > -#define CHILD_QDISC_OPS pfifo_qdisc_ops > - > static inline int WLAN_FC_IS_QOS_DATA(u16 fc) { > return (fc & 0x8C) == 0x88; > @@ -433,7 +431,7 @@ static int wme_qdiscop_init(struct Qdisc > /* create child queues */ > for (i = 0; i < queues; i++) { > skb_queue_head_init(&q->requeued[i]); > - q->queues[i] = qdisc_create_dflt(qd->dev, &CHILD_QDISC_OPS); > + q->queues[i] = qdisc_create_dflt(qd->dev, &pfifo_qdisc_ops); > if (q->queues[i] == 0) { > q->queues[i] = &noop_qdisc; > printk(KERN_ERR "%s child qdisc %i creation failed", dev->name, > i); > Index: wireless-dev/net/d80211/Kconfig > =================================================================== > --- wireless-dev.orig/net/d80211/Kconfig > +++ wireless-dev/net/d80211/Kconfig > @@ -3,6 +3,7 @@ config D80211 > select CRYPTO > select CRYPTO_ARC4 > select CRYPTO_AES > + select NET_SCHED pfifo_fast is available even without CONFIG_NET_SCHED, maybe thats a better choice to avoid unnecessary bloat. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
