On Wed, Oct 25, 2006 at 03:01:29PM -0400, Jeff Garzik wrote: > On Wed, Oct 25, 2006 at 11:42:44AM -0700, David Kimdon wrote: > > Continue d80211 bitfield removal. In general, compilers have > > difficulty generating efficient code for bitfields. This patchset > > removes all bitfields from include/net/d80211.h. > > > > I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags > > structure member. Larger bitfields I converted into their > > u8/u16/whatever equivalent. > > For bit flags, usually it is best to use up to 32 bits of an > unsigned long, which guarantees that you use a machine integer for > all platforms.
That is how I originally had the patch, but then had a question about increasing structure size so I dropped flags to u16 or u8 for structures that were made larger by the bitfield removal. For the key_conf bitfields size doesn't matter much. For the tx_control bitfields size matters a bit more since it is needed per-packets and dirvers currently need to store a copy to pass to the tx complete handler. Thoughts? David - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
