On Sun, Oct 07, 2018 at 07:29:13PM -0600, David Ahern wrote: > On 10/7/18 4:29 AM, Christian Brauner wrote: > >> I thought about that, but there is so much overlap - they are mostly > >> common. Besides, ifinfomsg is the header for link dumps, and ifinfomsg > >> is the one that has been (ab)used for other message types, so strict > >> versus lenient does not really have a differentiator for this message > >> type - other than checking the elements of the struct. > > > > It's mostly about the function being extremely long and convoluted. > > Having parts moved out into (a) descriptive helper(s) with whatever name > > might make this way more readable than it is now especially with the new > > handling we need for strict checking. > > > > understood. In the next version I have pushed most of the checking into > helpers.
Thank you!
