On Tue, Oct 02, 2018 at 10:24:19AM +0300, Eran Ben Elisha wrote:
> Struct sff_diags can be used uninitialized at sff8636_show_dom, this
> caused the tool to show unreported fields (supports_alarms) by the lower
> level driver.
> 
> In addition, make sure the same struct is being initialized at
> sff8472_parse_eeprom function, to avoid the same issue here.
> 
> Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information 
> Support")
> Signed-off-by: Eran Ben Elisha <era...@mellanox.com>

Hi Eran

Thanks for fixing both cases.

Reviewed-by: Andrew Lunn <and...@lunn.ch>

    Andrew

Reply via email to