For most normal sends, the netpoll code was using the dev->hard_start_xmit
directly. If it got busy, it would process later, but this code path uses
dev_queue_xmit() and that code would send the skb through NIT and other
stuff that netpoll doesn't want.

Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>

--- netpoll.orig/net/core/netpoll.c
+++ netpoll/net/core/netpoll.c
@@ -51,17 +51,28 @@ static atomic_t trapped;
 static void zap_completion_queue(void);
 static void arp_reply(struct sk_buff *skb);
 
+static void queue_process(void *);
+static DECLARE_WORK(send_queue, queue_process, NULL);
+
 static void queue_process(void *p)
 {
        struct sk_buff *skb;
 
-       while ((skb = skb_dequeue(&netpoll_txq)))
-               dev_queue_xmit(skb);
+       while ((skb = skb_dequeue(&netpoll_txq))) {
+               struct net_device *dev = skb->dev;
+               netif_tx_lock_bh(dev);
+               if (netif_queue_stopped(dev) ||
+                   dev->hard_start_xmit(skb, dev) != NETDEV_TX_OK) {
+                       skb_queue_head(&netpoll_txq, skb);
+                       netif_tx_unlock_bh(dev);
 
+                       schedule_delayed_work(&send_queue, 1);
+                       break;
+               }
+               netif_tx_unlock_bh(dev);
+       }
 }
 
-static DECLARE_WORK(send_queue, queue_process, NULL);
-
 void netpoll_queue(struct sk_buff *skb)
 {
        skb_queue_tail(&netpoll_txq, skb);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to