This series contains bug fixes to the ice driver. Anirudh provides several fixes, starting with static analysis fixes by replacing a bitwise-and with a constant value and replace "magic" numbers with defines. Fixed the control queue processing by removing unnecessary read/writes to registers, as well as getting a accurate value for "pending". Added additional checks to avoid NULL pointer dereferences. Fixed up code formatting issues, by cleaning up code comments and coding style.
Bruce cleans up a duplicate check for owner, within the same function. Also cleans up interrupt causes that are not handled or applicable. Fix checkpatch warning about the use of bool in structures due to the wasted space and size of bool, so convert struct members to u8 instead. Jake fixes a number of potential bugs in the reporting of stats via ethtool, by simply reporting all the queue statistics, even for the queues that are not activated. Fixed a compiler warning, as well as make the code a bit cleaner but just using order_base_2() for calculating the power-of-2. Preethi adds a check to avoid a NULL pointer dereference crash during initialization. Brett clarifies the code when it comes to port VLANs and regular VLANs, by renaming defines and field values to match their intended use and purpose. Jesse initializes a variable to avoid garbage values being returned to the caller. The following are changes since commit 0d092f06faa46b95a8e07b9bb5737b7c0f1176ee: Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth and are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue 100GbE Anirudh Venkataramanan (5): ice: Fix multiple static analyser warnings ice: Cleanup magic number ice: Fix bugs in control queue processing ice: Fix a few null pointer dereference issues ice: Trivial formatting fixes Brett Creeley (1): ice: Set VLAN flags correctly Bruce Allan (3): ice: Remove unnecessary node owner check ice: Update to interrupts enabled in OICR ice: Change struct members from bool to u8 Jacob Keller (2): ice: Report stats for allocated queues via ethtool stats ice: Use order_base_2 to calculate higher power of 2 Jesse Brandeburg (1): ice: Fix potential return of uninitialized value Preethi Banala (1): ice: Clean control queues only when they are initialized drivers/net/ethernet/intel/ice/ice.h | 15 ++- .../net/ethernet/intel/ice/ice_adminq_cmd.h | 25 ++-- drivers/net/ethernet/intel/ice/ice_common.c | 30 +++-- drivers/net/ethernet/intel/ice/ice_controlq.c | 29 +++-- drivers/net/ethernet/intel/ice/ice_ethtool.c | 52 ++++++-- .../net/ethernet/intel/ice/ice_hw_autogen.h | 8 -- .../net/ethernet/intel/ice/ice_lan_tx_rx.h | 1 + drivers/net/ethernet/intel/ice/ice_main.c | 115 ++++++++++-------- drivers/net/ethernet/intel/ice/ice_nvm.c | 5 +- drivers/net/ethernet/intel/ice/ice_sched.c | 3 +- drivers/net/ethernet/intel/ice/ice_switch.c | 4 +- drivers/net/ethernet/intel/ice/ice_switch.h | 6 +- drivers/net/ethernet/intel/ice/ice_txrx.h | 2 +- drivers/net/ethernet/intel/ice/ice_type.h | 16 +-- 14 files changed, 185 insertions(+), 126 deletions(-) -- 2.17.1
