Hi David, I love your patch! Yet something to improve:
[auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/dsahern-kernel-org/veth-Free-queues-on-link-delete/20180816-073955 config: i386-randconfig-x016-201832 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers//net/veth.c: In function 'veth_dellink': >> drivers//net/veth.c:476:2: error: implicit declaration of function >> 'veth_free_queues'; did you mean 'veth_dev_free'? >> [-Werror=implicit-function-declaration] veth_free_queues(dev); ^~~~~~~~~~~~~~~~ veth_dev_free cc1: some warnings being treated as errors vim +476 drivers//net/veth.c 470 471 static void veth_dellink(struct net_device *dev, struct list_head *head) 472 { 473 struct veth_priv *priv; 474 struct net_device *peer; 475 > 476 veth_free_queues(dev); 477 priv = netdev_priv(dev); 478 peer = rtnl_dereference(priv->peer); 479 480 /* Note : dellink() is called from default_device_exit_batch(), 481 * before a rcu_synchronize() point. The devices are guaranteed 482 * not being freed before one RCU grace period. 483 */ 484 RCU_INIT_POINTER(priv->peer, NULL); 485 unregister_netdevice_queue(dev, head); 486 487 if (peer) { 488 priv = netdev_priv(peer); 489 RCU_INIT_POINTER(priv->peer, NULL); 490 unregister_netdevice_queue(peer, head); 491 } 492 } 493 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
