On Wed, Aug 15, 2018 at 8:47 AM, Y Song <ys114...@gmail.com> wrote: > On Wed, Aug 15, 2018 at 7:57 AM, Jesper Dangaard Brouer > <bro...@redhat.com> wrote: >> It is common XDP practice to unload/deattach the XDP bpf program, >> when the XDP sample program is Ctrl-C interrupted (SIGINT) or >> killed (SIGTERM). >> >> The samples/bpf programs xdp_redirect_cpu and xdp_rxq_info, >> forgot to trap signal SIGTERM (which is the default signal used >> by the kill command). >> >> This was discovered by Red Hat QA, which automated scripts depend >> on killing the XDP sample program after a timeout period. >> >> Fixes: fad3917e361b ("samples/bpf: add cpumap sample program >> xdp_redirect_cpu") >> Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to >> xdp_rxq_info") >> Reported-by: Jean-Tsung Hsiao <jhs...@redhat.com> >> Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com> > > Acked-by: Yonghong Song <y...@fb.com>
Reviewed-by: Song Liu <songliubrav...@fb.com> > >> --- >> samples/bpf/xdp_redirect_cpu_user.c | 3 ++- >> samples/bpf/xdp_rxq_info_user.c | 3 ++- >> 2 files changed, 4 insertions(+), 2 deletions(-)