On 8/14/18 7:16 PM, Toshiaki Makita wrote: > Hmm, on second thought this queues need to be freed after veth_close() > to make sure no packet will reference them. That means we need to free > them in .ndo_uninit() or destructor. > (rtnl_delete_link() calls dellink() before unregister_netdevice_many() > which calls dev_close_many() through rollback_registered_many()) > > Currently veth has destructor veth_dev_free() for vstats, so we can free > queues in the function. > To be in line with vstats, allocation also should be moved to > veth_dev_init().
given that, can you take care of the free in the proper location?