From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Wed, 18 Oct 2006 07:08:07 +0200

> Each route entry includes a 'struct flow'. This structure has a
> current size of 80 bytes. This patch makes a size reduction
> depending on
> CONFIG_IPV6/CONFIG_IPV6_MODULE/CONFIG_DECNET/CONFIG_IP_ROUTE_FWMARK
> For a platform doing IPV4 only, the new size is 36 bytes (instead of
> 80) As many routers are base on PIII (L1_CACHE_SIZE=32), this saves
> one cache line per rtable entry.

I don't like these kinds of patches because %99 of people will never
ever realize the "savings" because distribution vendors will always,
unlaterally, enable everything.

For example, I'm still pending to cut the patch that kills the "struct
flow" from inet_sock's cork area since it really isn't needed.

I'd rather do things that get rid of the size in a way that benefits
everyone, regardless of kernel config.  I also would totally support
a patch that got rid of all the config ifdefs used in struct sk_buff.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to