From: David Miller <da...@davemloft.net> Date: Fri, 10 Aug 2018 14:35:45 -0700 (PDT)
> From: Michael Chan <michael.c...@broadcom.com> > Date: Fri, 10 Aug 2018 17:02:12 -0400 > >> From: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> >> >> This patch fixes following smatch warnings: >> >> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2826 >> bnxt_fill_coredump_seg_hdr() error: strcpy() '"sEgM"' too large for >> 'seg_hdr->signature' (5 vs 4) >> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2858 >> bnxt_fill_coredump_record() error: strcpy() '"cOrE"' too large for >> 'record->signature' (5 vs 4) >> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2879 >> bnxt_fill_coredump_record() error: strcpy() 'utsname()->sysname' too large >> for 'record->os_name' (65 vs 32) >> >> Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.") >> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> >> Signed-off-by: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> >> Signed-off-by: Michael Chan <michael.c...@broadcom.com> > > Applied, thanks Michael. Actually, I'm reverting, this may fix those three warnings, but they are replaced with a new one: ./include/linux/string.h:246:9: warning: ‘__builtin_strncpy’ output may be truncated copying 32 bytes from a string of length 64 [-Wstringop-truncation] Sorry.