Wed, Jul 25, 2018 at 12:14:32PM CEST, pab...@redhat.com wrote:
>On Tue, 2018-07-24 at 14:15 -0700, Cong Wang wrote:
>> On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni <pab...@redhat.com> wrote:
>> > +
>> > + /* let's the caller reinject the packet, if possible */
>> > + if (skb_at_tc_ingress(skb)) {
>> > + res->ingress = want_ingress;
>> > + res->qstats = this_cpu_ptr(m->common.cpu_qstats);
>> > + return TC_ACT_REINJECT;
>> > + }
>>
>> Looks good to me, but here we no longer return user-specified
>> return value here, I am sure it is safe for TC_ACT_STOLEN, but
>> I am not sure if it is safe for other values, like TC_ACT_RECLASSIFY.
>
>I can make it safer, using the no clone path only if tcf_action is
>TC_ACT_STOLEN. That will still cover the relevant use-cases.
That is a good idea. Thanks!
>
>Will do that in v4.
>
>Cheers,
>
>Paolo
>
