On 19/07/2018 8:25 PM, Cong Wang wrote:
On Thu, Jul 19, 2018 at 7:34 AM Tariq Toukan <tar...@mellanox.com> wrote:
Fix dev_change_tx_queue_len so it rolls back original value
upon a failure in dev_qdisc_change_tx_queue_len.
This is already done for notifirers' failures, share the code.
The revert of changes in dev_qdisc_change_tx_queue_len
in such case is needed but missing (marked as TODO), yet it is
still better to not apply the new requested value.
You misunderstand the TODO, that is for reverting tx queue len
change for previous queues in the loop. I still don't have any
nice solution for this yet.
I understood this, but maybe didn't describe it clearly. I'll re-phrase.
Yeah, your change itself looks good.
Thanks.
Please update the changelog.
Thanks.
