Re: [net 4/8] net/mlx5e: Don't allow aRFS for encapsulated packets

[Or Gerlitz]

On Thu, Jul 19, 2018 at 4:26 AM, Saeed Mahameed <sae...@mellanox.com> wrote:
> From: Eran Ben Elisha <era...@mellanox.com>
>
> Driver is yet to support aRFS for encapsulated packets, return early
> error in such case.


Eran,

Isn't that something which is done wrong by the arfs stack code?

If the kernel has an SKB which has encap set and an arfs steering
rule is programed into the driver, the API should include a driver neutral
description for the encap header for the HW to match, so maybe we can just do

diff --git a/net/core/dev.c b/net/core/dev.c
index 0df1771..b93008f 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3934,6 +3934,10 @@ set_rps_cpu(struct net_device *dev, struct sk_buff *skb,
                flow_table = rcu_dereference(rxqueue->rps_flow_table);
                if (!flow_table)
                        goto out;
+
+               if (skb->encapsulation)
+                       return -EPROTONOSUPPORT;
+
                flow_id = skb_get_hash(skb) & flow_table->mask;
                rc = dev->netdev_ops->ndo_rx_flow_steer(dev, skb,
                                                        rxq_index, flow_id);