Hi Stefano, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Stefano-Brivio/net-Move-skb-decrypted-field-avoid-explicity-copy/20180717-152125 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=ia64 All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:10, from include/linux/list.h:9, from include/linux/module.h:9, from net//core/skbuff.c:41: net//core/skbuff.c: In function '__copy_skb_header': >> net//core/skbuff.c:787:31: error: attempt to take address of bit-field >> structure member 'decrypted' BUILD_BUG_ON(offsetof(struct sk_buff, field) < \ ^~~~~~~ include/linux/compiler.h:316:19: note: in definition of macro '__compiletime_assert' bool __cond = !(condition); \ ^~~~~~~~~ include/linux/compiler.h:339:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:45:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:69:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~~~~~~~~~~~~~ net//core/skbuff.c:787:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(offsetof(struct sk_buff, field) < \ ^~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) ^~~~~~~~~~~~~~~~~~~ net//core/skbuff.c:787:15: note: in expansion of macro 'offsetof' BUILD_BUG_ON(offsetof(struct sk_buff, field) < \ ^~~~~~~~ net//core/skbuff.c:837:2: note: in expansion of macro 'CHECK_SKB_FIELD' CHECK_SKB_FIELD(decrypted); ^~~~~~~~~~~~~~~ net//core/skbuff.c:789:31: error: attempt to take address of bit-field structure member 'decrypted' BUILD_BUG_ON(offsetof(struct sk_buff, field) > \ ^~~~~~~ include/linux/compiler.h:316:19: note: in definition of macro '__compiletime_assert' bool __cond = !(condition); \ ^~~~~~~~~ include/linux/compiler.h:339:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:45:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:69:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~~~~~~~~~~~~~ net//core/skbuff.c:789:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(offsetof(struct sk_buff, field) > \ ^~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) ^~~~~~~~~~~~~~~~~~~ net//core/skbuff.c:789:15: note: in expansion of macro 'offsetof' BUILD_BUG_ON(offsetof(struct sk_buff, field) > \ ^~~~~~~~ net//core/skbuff.c:837:2: note: in expansion of macro 'CHECK_SKB_FIELD' CHECK_SKB_FIELD(decrypted); ^~~~~~~~~~~~~~~ vim +/decrypted +787 net//core/skbuff.c 795bb1c0 Jesper Dangaard Brouer 2016-02-08 784 b1937227 Eric Dumazet 2014-09-28 785 /* Make sure a field is enclosed inside headers_start/headers_end section */ b1937227 Eric Dumazet 2014-09-28 786 #define CHECK_SKB_FIELD(field) \ b1937227 Eric Dumazet 2014-09-28 @787 BUILD_BUG_ON(offsetof(struct sk_buff, field) < \ b1937227 Eric Dumazet 2014-09-28 788 offsetof(struct sk_buff, headers_start)); \ b1937227 Eric Dumazet 2014-09-28 789 BUILD_BUG_ON(offsetof(struct sk_buff, field) > \ b1937227 Eric Dumazet 2014-09-28 790 offsetof(struct sk_buff, headers_end)); \ b1937227 Eric Dumazet 2014-09-28 791 :::::: The code at line 787 was first introduced by commit :::::: b1937227316417aa7568d01e6fa1f272e98fb890 net: reorganize sk_buff for faster __copy_skb_header() :::::: TO: Eric Dumazet <eduma...@google.com> :::::: CC: David S. Miller <da...@davemloft.net> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
