On Monday 09 October 2006 12:03 pm, Stephen Hemminger wrote:
> On Mon, 9 Oct 2006 11:09:39 -0700
>
> Misha Tomushev <[EMAIL PROTECTED]> wrote:
> > On Sunday 08 October 2006 12:27 am, Pavel Machek wrote:
> > > Hi!
> > >
> > > > + ecmd->phy_address = 0; /* !!! Stole from e1000 */
> > > > + ecmd->speed = 3; /* !!! Stole from e1000 */
> > >
> > > Eh?
> >
> > You are right. Will fix.
> >
> > > > +static void vnic_get_regs(struct net_device *netdev,
> > > > + struct ethtool_regs *regs, void *p)
> > > > +{
> > > > + struct vnic_device *vnicdev = netdev->priv;
> > > > + struct vioc_device *viocdev = vnicdev->viocdev;
> > >
> > > This looks ugly. What interface is that?
> Please just dump binary like other drivers. The code for ethtool allows
> per device decode. Move the decode to there.
>
> Yes, ethtool source does need a more generic register description language.
Signed-off-by: Misha Tomushev <[EMAIL PROTECTED]>
Please pull the patch from
ftp://ftp.fabric7.com/VIOC/vioc_patch.2006-10-12-17-40
--
Misha Tomushev
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
